Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp app registry and add parameter to control file creation #2137

Merged
merged 7 commits into from
Oct 7, 2021

Conversation

ishank011
Copy link
Contributor

No description provided.

pkg/app/registry/static/static.go Outdated Show resolved Hide resolved
pkg/app/registry/static/static.go Outdated Show resolved Hide resolved
@ishank011 ishank011 force-pushed the app-registry-revamp branch from 937bb6e to 5b2370e Compare October 7, 2021 10:23
glpatcern
glpatcern previously approved these changes Oct 7, 2021
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already discussed, looks good to me, including the fact that /app/list will return the whole list of mimetypes for which an application was registered.

@glpatcern
Copy link
Member

My comment crossed Willy's (I had it there in the review and only now I clicked the button). Let's see then, how/if to resume the white listing.

@glpatcern glpatcern merged commit 9be4c4f into cs3org:master Oct 7, 2021
@ishank011 ishank011 deleted the app-registry-revamp branch October 7, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants